Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebs: calc full snapshot size and report backup size for failed backup #5007

Merged
merged 7 commits into from
May 25, 2023
Merged

ebs: calc full snapshot size and report backup size for failed backup #5007

merged 7 commits into from
May 25, 2023

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented May 12, 2023 •
edited
Loading

What problem does this PR solve?

Closes #4993

What is changed and how does it work?

  1. Backup size attribute of a backup CR is now the expected size after restore instead of the delta.
  2. Backup size will be reported for both successful and failed ebs backup job
  3. No need to recalculate backupsize at clean time

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • WangLe1321
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from handlerww and liubog2008 May 12, 2023 11:48
@BornChanger
Copy link
Contributor Author

/cc @WangLe1321 @csuzhangxc

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind-br

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023 •
edited
Loading

Codecov Report

Merging #5007 (3ee148e) into master (eaae778) will increase coverage by 3.93%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5007      +/-   ##
==========================================
+ Coverage   56.98%   60.91%   +3.93%     
==========================================
  Files         243      247       +4     
  Lines       27504    30686    +3182     
==========================================
+ Hits        15673    18693    +3020     
- Misses      10300    10342      +42     
- Partials     1531     1651     +120
Flag Coverage Δ
e2e 30.71% <ø> (?)
unittest 57.16% <0.00%> (+0.17%) ⬆️

@BornChanger BornChanger mentioned this pull request May 17, 2023
Open
@ti-chi-bot ti-chi-bot bot removed the needs-rebase label May 17, 2023
@BornChanger
*: list full snapshot size
2b1145b 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: report the backup size for failed backup
4bd72e7 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: polish code
5489c94 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: move the ebs backupsize calc to defer() function
0339434 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: fix comment
684e4d4 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: polish code
4b10d43 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
Copy link
Contributor Author

/review default

@BornChanger
*: clean up redundant code
3ee148e 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
Copy link
Contributor Author

/retest

1 similar comment
@BornChanger
Copy link
Contributor Author

/retest

@csuzhangxc csuzhangxc merged commit 6c37c64 into pingcap:master May 25, 2023
@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 3, 2023

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5130.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2023
Closed
10 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb-operator that referenced this pull request Jul 3, 2023
@BornChanger @ti-chi-bot
This is an automated cherry-pick of pingcap#5007
be1a9f2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 4, 2023

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5138.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 4, 2023
Merged
10 tasks
csuzhangxc pushed a commit that referenced this pull request Jul 4, 2023
@ti-chi-bot @BornChanger
ebs: calc full snapshot size and report backup size for failed backup (…
3d17117 
…#5007) (#5138)

Signed-off-by: BornChanger <dawn_catcher@126.com>
Co-authored-by: BornChanger <dawn_catcher@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangLe1321 WangLe1321 WangLe1321 approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@handlerww handlerww Awaiting requested review from handlerww

@liubog2008 liubog2008 Awaiting requested review from liubog2008

Assignees
No one assigned
Labels
area/ebs-br status/LGT2 type/cherry-pick-for-release-1.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ebs br: calculate ebs snapshot size for failed backup
5 participants
@BornChanger @codecov-commenter @ti-chi-bot @csuzhangxc @WangLe1321